Report error for native PDB limit #75293
Conversation
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jjonescz
force-pushed
the
75237-NativePdbOom
branch
from
50985e8
to
490b67a
Compare
| methodBody.MethodDefinition, | ||
| blob.Length, | ||
| limit)); | ||
| } |
There was a problem hiding this comment.
Note: the name of the attribute is part of the limit length. Is that included in the blob?
There was a problem hiding this comment.
No, the name is not included in the blob. You are right the limit is wrong now, will fix.
There was a problem hiding this comment.
Why did you put the check here vs. inside DefineCustomMetadata? Yes this is the only call today but in the future if we added more calls we wouldn't get this protection.
There was a problem hiding this comment.
You are right, it seems better to move the check into DefineCustomMetadata. I originally chose this location because it's where I have access to the method name, but I can probably pass that down or rethrow an exception...
|
@dotnet/roslyn-compiler @jaredpar for a second review, thanks |
Resolves #75237.